Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Wind Features 2024 #1186

Merged
merged 31 commits into from
Oct 15, 2024
Merged

New Wind Features 2024 #1186

merged 31 commits into from
Oct 15, 2024

Conversation

janinefreeman
Copy link
Collaborator

This pull request adds a variety of new features to the wind model, currently accessible only programmatically.

New features include:

  • additional wake loss outputs, including a timeseries wake loss output (available in the UI as well) <- @cpaulgilman these may need to be documented
    --also separates "internal" wake losses (i.e. calculated by a wake model) from external wake losses (i.e. from other plants)
  • new optional input to the Park wake model to overwrite the calculated coefficient of thrust
  • new optional input to use a different wake decay constant in the Park model
  • an optional wake loss multiplier to proportionally change the total annual wake losses calculated by the compute module
  • optional "icing persistence" input, which allows the user to specify the number of timesteps that an icing shutdown should last (more realistic behavior than assuming the turbine can start/stop as conditions change)

Tests have been added to cover these new features.

Bug fix for #1143 included in this PR.

@dguittet I think you're the best reviewer for this, but note that this is not an urgent PR. :) I did not generate the the new API files for these new inputs, but maybe I can get your help with that when you have some time?

janinefreeman and others added 24 commits February 29, 2024 10:40
@janinefreeman
add wake model enum for clarity
94b1b1c
@janinefreeman
add timeseries and additional annual wake loss outputs to the wind mo…
7e3082e 
…del, renamed wake loss variables and outputs for clarity
@janinefreeman
updated some annual energy outputs in wind model, fixes #1143
927bbf2
@janinefreeman
Merge branch 'develop' into wind2024updates
6b3eeb3
@janinefreeman
update annual wake loss outputs in wind model to be more clear and pr…
52e941c 
…ovide additional values
@janinefreeman
update wind tests for new wake loss output names
3e2b820
@janinefreeman
added optional wake decay constant for park wake model in wind model …
beab282 
…and updated test accordingly
@janinefreeman
Merge branch 'develop' into wind2024updates
2cd6462
@janinefreeman
added optional wake loss multiplier input to wind model
e0abe34
@janinefreeman
added a new wind test for the wake model loss multiplier
fc8c310
@janinefreeman
added optional coefficient of thrust curve input to cmod_windpower fo…
a0958b1 
…r the park wake model. placeholder for functionality of using the input needs to be updated.
@janinefreeman
Merge branch 'develop' into wind2024updates
7dcbd75
@janinefreeman
change implementation of optional user-defined thrust coefficient cur…
1aeaa7f 
…ve to belong to wind turbine class so that it will be available to all wake models
@janinefreeman
added functionality to overwrite calculated coefficient of thrust wit…
93b5771 
…h a user-defined Ct curve for all wind wake models
@janinefreeman
modified where coefficient of thrust is initialized
762f489
@janinefreeman
updated ctcurve initialization
419458a
@janinefreeman
Merge branch 'develop' into wind2024updates
b67c957
@janinefreeman
add check for power curve existence in thrust curve set function and …
a3393f5 
…update wake loss output names per Paul suggestions
@janinefreeman
added a test for the thrust curve input to wind compute module, still…
b583981 
… needs to be completed
@janinefreeman
updated wind test
aa4f910
@janinefreeman
fixed variable ingestion of ct curve in wind cmod and updated thrust …
4d77818 
…curve test
@janinefreeman
Merge branch 'develop' into wind2024updates
4b83850
@janinefreeman
Merge branch 'develop' into wind2024updates
6fb0126
@janinefreeman
added icing loss persistence input to allow icing loss to last for mo…
e1289c0 
…re than just the timestep triggering the loss
@janinefreeman janinefreeman added this to the SAM Fall 2024 Release milestone Jul 21, 2024
dguittet
dguittet reviewed Jul 30, 2024
View reviewed changes
ssc/cmod_windpower.cpp Outdated Show resolved Hide resolved
dguittet
dguittet requested changes Jul 30, 2024
View reviewed changes
ssc/cmod_windpower.cpp Show resolved Hide resolved
test/ssc_test/cmod_windpower_test.cpp Show resolved Hide resolved
dguittet
dguittet approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janinefreeman janinefreeman merged commit 8e8c06f into develop Oct 15, 2024
8 checks passed
@janinefreeman janinefreeman deleted the wind2024updates branch October 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguittet dguittet dguittet approved these changes

Assignees
No one assigned
Labels
new feature requires SAM Help revision wind
Projects
None yet
Milestone
SAM Fall 2024 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@janinefreeman @dguittet